Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Flowbite::Link component for rendering styled hyperlinks with default Flowbite styling. The component supports custom attributes via options and uses the Rails link_to helper.
- Adds
Flowbite::Linkcomponent class with default styling - Includes tests for basic rendering and attribute handling
- Adds Lookbook preview for documentation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| app/components/flowbite/link.rb | New component implementing styled link with Flowbite CSS classes |
| test/components/flowbite/link_test.rb | Unit tests for link rendering and attribute passing |
| demo/test/components/previews/link_preview.rb | Preview example for Lookbook documentation |
| CHANGELOG.md | Documents the addition of the Link component |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Honestly, you should probably use <%= link_to %> directly, but here we
are. At least we can now do
<%= link_to(..., class: Flowbite::Link.classes) %>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.