Conversation
Prefer `title_hint` over `_title_hint` for forms without an object
koppen
force-pushed
the
objectless_forms
branch
from
4e82b44 to
9ecac9b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for non-object based forms (created with form_tag) to Flowbite input components, expanding compatibility beyond the existing form_for and form_with implementations.
Key Changes
- Added nil-safety checks for
@objectin error-related methods across input components - Modified
id_for_hint_elementto usecompact_blankpattern for building IDs whenform.object_namemay be nil - Added comprehensive test suite (
Flowbite::InputFieldWithoutObjectTest) covering input fields and selects without form objects
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
app/components/flowbite/input_field.rb |
Added nil check in errors method and refactored id_for_hint_element to handle nil object names using compact_blank |
app/components/flowbite/input/label.rb |
Added nil check in errors? method to prevent NoMethodError on nil objects |
app/components/flowbite/input/field.rb |
Added nil check in errors? method with documentation explaining the behavior |
test/components/flowbite/input_field_test.rb |
Added complete test suite (153 lines) mirroring object-based tests but using forms without objects |
CHANGELOG.md |
Documented the new feature under "Added" section in Unreleased |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.