fix: allow any1s in struct return type in YAML extensions #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
=======================================
Coverage 68.79% 68.79%
=======================================
Files 45 45
Lines 10367 10367
=======================================
Hits 7132 7132
Misses 2886 2886
Partials 349 349 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benbellick
commented
Jan 20, 2026
| // For concrete types: returns itself unchanged. | ||
| // | ||
| // Note: The same type may appear in both parameter and return positions (e.g., any1 | ||
| // as a parameter and nested inside struct<any1>). This interface covers both cases. |
Member
Author
There was a problem hiding this comment.
I added this comment because I found this function very confusing. I think there is opportunity to improve this API, but that can be saved for another PR.
benbellick
commented
Jan 20, 2026
| } | ||
|
|
||
| func (d *DataTypeUDTParam) toTypeParam() (TypeParam, error) { | ||
| // TODO(#184): Pass funcParams and argTypes to support polymorphic types (any, any1, etc.) |
Member
Author
There was a problem hiding this comment.
Wanted to keep the diff small and this one seemed a tiny bit more involved than the others.
This one is a little extra just to be safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #182