feat(isthmus): support EXISTS and UNIQUE set predicates#354
Merged
vbarua merged 1 commit intosubstrait-io:mainfrom Mar 27, 2025
Merged
feat(isthmus): support EXISTS and UNIQUE set predicates#354vbarua merged 1 commit intosubstrait-io:mainfrom
vbarua merged 1 commit intosubstrait-io:mainfrom
Conversation
9292b21 to
2502697
Compare
vbarua
approved these changes
Mar 26, 2025
Member
vbarua
left a comment
There was a problem hiding this comment.
Looks good overall. Left one minor usability improvment.
isthmus/src/main/java/io/substrait/isthmus/expression/ExpressionRexConverter.java
Outdated
Show resolved
Hide resolved
2502697 to
9017cfa
Compare
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
9017cfa to
934fdb5
Compare
vbarua
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be merged after #353 since it shares the same test infrastructure.
Currently, the Substrait to Calcite mappings do not support exists and unique set predicates like the follow SQL example from TPC-H query no. 4:
This PR adds support for mapping exists and unique set predicates from Substrait into Calcite and adds a test case showing that it works now.