build: make spotless run more reliably#358
Merged
vbarua merged 1 commit intosubstrait-io:mainfrom Mar 27, 2025
Merged
Conversation
nielspardon
force-pushed
the
par-spotless
branch
from
44f8302 to
7a3dcfb
Compare
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
nielspardon
force-pushed
the
par-spotless
branch
from
7a3dcfb to
99b051f
Compare
vbarua
approved these changes
Mar 27, 2025
Member
vbarua
left a comment
vbarua
left a comment
There was a problem hiding this comment.
Tested ./gradlew spotlessJavaApply and spotless is still applied as expected. Changes look reasonable to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I run
./gradlew clean buildon my local clone I constantly see Spotless tripping up on files in thebuildfolder no longer existing which means I have to run the command multiple times. This suggests to me that thetargetExcludeconfiguration does not work as expected.Instead this PRs configures the
targetto format every*.javafile within any of thesrc/*/java/**directories which works more reliably and achieves the same goal as the current configuration.This PR also adds
.metalsto the.gitignorefor the VS Code users among us which uses metals for the Scala code.