fix: javadoc for the isthmus library #645
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MBWhite <[email protected]>
nielspardon
requested review from
andrew-coleman,
benbellick,
bestbeforetoday and
vbarua
nielspardon
reviewed
Jan 8, 2026
Comment on lines
+49
to
52
| * @return the number of outer scopes between the access and its correlation source, or {@code | ||
| * null} if not tracked | ||
| */ | ||
| public int getStepsOut(RexFieldAccess fieldAccess) { |
Member
There was a problem hiding this comment.
that makes me wonder if we would need to change the method return type given that it's declared as a primitive int and not an Integer meaning it can not be null
Member
There was a problem hiding this comment.
looks like this method is not called anywhere in the current code base
Contributor
Author
There was a problem hiding this comment.
yes that's a good point... it does seem redundant
nielspardon
reviewed
Jan 8, 2026
|
|
||
| // For example, if a grouping is defined as (0, 2, 1) in Substrait, Calcite will output it as | ||
| // (0, 1, 2), which means that the Calcite output will no longer line up with the expectations | ||
| // of the Substrait plan. |
Member
There was a problem hiding this comment.
I'm not sure how I feel about removing this much information. I'm wondering whether we should better preserve this somehow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.