feat: update LLVM to latest version as of Jan. 31, 2025 (956cfa69b15) #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingomueller-net
force-pushed
the
update-llvm
branch
from
408c04d to
434a789
Compare
ingomueller-net
changed the title
ingomueller-net
force-pushed
the
update-llvm
branch
from
434a789 to
baaad6a
Compare
This PR updates the LLVM git submodule to the latest version as of January 31, 2025, namely llvm/llvm-project@956cfa69b15. Signed-off-by: Ingo Müller <[email protected]>
Signed-off-by: Ingo Müller <[email protected]>
The way `FloatType`s are built was changed upstream: instead of `FloatType::getF32`, we now use `Float32Type::get`. This commit adapts the usages of the previous pattern. While touching that code, the commit also refactors both `exportFloatType` and `exportIntegerType` to use a `switch` statement on the type width instead of constructing all possible MLIR types and comparing linearly against them, which is less efficient. Signed-off-by: Ingo Müller <[email protected]>
Signed-off-by: Ingo Müller <[email protected]>
ingomueller-net
force-pushed
the
update-llvm
branch
from
baaad6a to
22834ab
Compare
jpienaar
approved these changes
Feb 6, 2025
Collaborator
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the LLVM git submodule to the latest version as of January 31, 2025, namely llvm/llvm-project@956cfa69b15 and adapts the code base to the new version. The concrete motivation for the update is llvm/llvm-project#124770, which fixes the
TypedStrAttrdefinition that #73 uses.This PR requires to update the git modules in existing git clones and to install new pip dependencies: