feat: default value for parameterConsistency #929
Conversation
benbellick
changed the title
benbellick
requested review from
EpsilonPrime,
cpcloud,
jacques-n,
vbarua,
westonpace and
yongchul
as code owners
extensions/functions_comparison.yaml
Outdated
| - value: any1 | ||
| variadic: | ||
| min: 2 | ||
| parameterConsistency: CONSISTENT |
There was a problem hiding this comment.
I added this to the docs in the note part of scalar_functions.md, but I believe that consistent vs inconsistent doesn't matter here. This is because any1 in the return type pins the argument.
There was a problem hiding this comment.
So I actually ended up removing this line. It falsely communicates to the user that parameterConsistency set to CONSISTENT is an important attribute here. In actuality, the any1 value is pinned by the return type, so all of them MUST be fixed, regardless of the parameterConsistency setting.
As part of this PR, I wanted to try and come up with some useful and standard scalar functions to add to the core extension set that demonstrate the use of both values of parameterConsistency, but I couldn't think of any or find any off the internet. This was introduced in 2021. Perhaps we should discuss if this feature is worth supporting?
There was a problem hiding this comment.
Okay actually, I found postgresql's JSON_BUILD_OBJECT, which is an example of a function where variadic INCONSISTENT behavior is desirable.
closes #928