Notes update #1380
Open
Notes update #1380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s all the notes from all the user's friends Created two new methods get_note_by_user that requires the username it returns a NoteResponse object and get_note_content_by_user that requires the username and returns the NoteRequest object, that only contains the text and uuid field. Fixed the get_all_notes that was returning a json text now it will return an array of NoteResponse
…ntent method that returns a NoteRequest
…e response content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note.py
Fixed the naming of the get_my_notes it was unclear the method returns all the notes from all the user's friends
Created two new methods get_note_by_user that requires the username it returns a NoteResponse object and get_note_content_by_user that requires the username and returns the NoteRequest object, that only contains the text and uuid field.
Fixed the get_all_notes that was returning a json text now it will return an array of NoteResponse that ease the process of retrieving information about a note like the username
extractor.py
Added an extract_note that returns a NoteResponse and extract_note_content method that returns a NoteRequest
types.py
Fixed some BaseModel declarations that were not named according to the response content
Updated the wiki as well