Improve Argument Filtering Performance and Logging in Tool Struct#2
Open
yunusemremeral wants to merge 1 commit intosuccinctlabs:mainfrom
Open
Improve Argument Filtering Performance and Logging in Tool Struct#2yunusemremeral wants to merge 1 commit intosuccinctlabs:mainfrom
yunusemremeral wants to merge 1 commit intosuccinctlabs:mainfrom
Conversation
…et for removed arguments, improving performance for large argument lists. Improved error handling in is_duplicate_opt_arg by logging warnings for non-UTF8 flags instead of panicking. Made log levels more explicit when ignoring duplicate optimization arguments. Refactored cflags_env for more concise and readable flag joining. Updated all comments to English for clarity and consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced argument filtering in the Tool struct by introducing a HashSet for removed arguments, improving performance for large argument lists.
Improved error handling in is_duplicate_opt_arg by logging warnings for non-UTF8 flags instead of panicking.
Made log levels more explicit when ignoring duplicate optimization arguments.
Refactored cflags_env for more concise and readable flag joining.
Updated all comments to English for clarity and consistency.