feat: integrate fault-proof challenger into sysgo #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fakedev9999
reviewed
Jan 4, 2026
| c.p.Require().NoError(err, "fault-proof challenger exited unexpectedly") | ||
| }) | ||
|
|
||
| err := c.sub.Start(c.execPath, c.args, []string{}) |
Member
There was a problem hiding this comment.
The lock is not held before c.sub.Start() is called. I think this could cause race when concurrent Start()/Stop() calls are made. Maybe low priority if we don't need such tests to be covered.
Author
There was a problem hiding this comment.
Good catch. A proper fix isn't trivial though: holding the lock through Start() risks deadlocks since sub.Start() can block and OnExit runs async. Given current usage (single Start/Stop, no concurrency), I'll leave as-is for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.