Skip to content

feat: Support Rust 1.88 by removing usage of Duration::from_mins - #2736

Merged
bergkvist merged 5 commits into
mainfrom
tobias/rust-1.88
Apr 27, 2026
Merged

feat: Support Rust 1.88 by removing usage of Duration::from_mins#2736
bergkvist merged 5 commits into
mainfrom
tobias/rust-1.88

Conversation

@bergkvist

Copy link
Copy Markdown
Contributor

Motivation

Users that are unable to upgrade from Rust 1.88 are currently also unable to use sp1 v6

Solution

Avoid using more recent features that are not compatible with Rust 1.88

To actually support Rust 1.88, this also depends on:

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@github-actions

github-actions Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor
Test Old New Diff
p256_test_verify_rand_lte_100 11911360 11900426 -0.0918 %
rustcrypto_bigint_test_bigint_mul_mod_special 1753913 1753913 0.0000 %
sha_test_sha2_v0_10_6_expected_digest_lte_100_times 1769091 1763341 -0.3250 %
sha_test_sha2_v0_10_8_expected_digest_lte_100_times 1766051 1768518 0.1397 %
bls12_381_tests_test_inverse_fp2_100 2766653 2766653 0.0000 %
bn_test_bn_test_g1_add_neg 306879 306879 0.0000 %
p256_test_recover_high_hash_high_recid 6452669 6132279 -4.9652 %
secp256k1_program_test_verify_v0_30_0_rand_lte_100 17145883 17115677 -0.1762 %
sha_test_sha3_expected_digest_lte_100_times 1609207 1609233 0.0016 %
curve25519_dalek_test_decompressed_noncanonical 7660 7660 0.0000 %
bls12_381_tests_test_bls_add_100 10502108 10502108 0.0000 %
curve25519_dalek_ng_test_zero_msm 125560 125560 0.0000 %
bls12_381_tests_test_inverse_fp_100 1416558 1416558 0.0000 %
curve25519_dalek_ng_test_zero_mul 108069 108069 0.0000 %
bn_test_bn_test_fq_partial_ord 184120 184120 0.0000 %
bls12_381_tests_test_bls_double_100 6348821 6348821 0.0000 %
bn_test_bn_test_fr_inverse_100 851812 851812 0.0000 %
bn_test_bn_test_g1_mul_zero 46120 46120 0.0000 %
keccack_test_expected_digest_lte_100 1714958 1716540 0.0922 %
curve25519_dalek_test_zero_msm 83636 83636 0.0000 %
bls12_381_tests_test_sqrt_fp_100 967594 1036486 7.1199 %
k256_test_recover_pubkey_infinity 98274 98274 0.0000 %
rustcrypto_bigint_test_bigint_mul_add_residue 1736516 1736494 -0.0013 %
curve25519_dalek_test_zero_mul 72086 72086 0.0000 %
secp256k1_program_test_recover_rand_lte_100 5490798 5482951 -0.1429 %
secp256k1_program_test_verify_rand_lte_100 17109330 17137914 0.1671 %
sha_test_sha2_v0_10_9_expected_digest_lte_100_times 1768582 1771641 0.1730 %
p256_test_recover_rand_lte_100 15948532 15968888 0.1276 %
sha_test_sha2_v0_9_9_expected_digest_lte_100_times 1263339 1259435 -0.3090 %
rust_crypto_rsa_test_pkcs_verify_100 28902241 28679936 -0.7692 %
k256_test_recover_rand_lte_100 4468111 4461663 -0.1443 %
curve25519_dalek_ng_test_decompressed_noncanonical 195590 195590 0.0000 %
secp256k1_program_test_recover_v0_30_0_rand_lte_100 5492670 5491985 -0.0125 %
curve25519_dalek_test_ed25519_verify 13288740 13288209 -0.0040 %
k256_test_recover_high_hash_high_recid 2140958 2217002 3.5519 %
curve25519_dalek_test_add_then_multiply 3089570 3049242 -1.3053 %
bn_test_bn_test_fq_inverse_100 834812 834812 0.0000 %
bn_test_bn_test_g1_msm_edge 406721 406721 0.0000 %
bn_test_bn_test_fq_sqrt_100 833212 833212 0.0000 %
curve25519_dalek_test_decompressed_expected_value 4262631 4503210 5.6439 %
k256_test_point_ops_edge_cases 33843 33843 0.0000 %
curve25519_dalek_ng_test_add_then_multiply 3737218 3519695 -5.8205 %
p256_test_recover_pubkey_infinity 102285 102285 0.0000 %
bls12_381_tests_test_sqrt_fp2_100 1911783 1721885 -9.9330 %
k256_test_schnorr_verify 5734586 5743967 0.1636 %
bn_test_bn_test_g1_add_100 986802 986809 0.0007 %
k256_test_verify_rand_lte_100 11930256 11906438 -0.1996 %
bn_test_bn_test_g1_double_100 727516 727495 -0.0029 %

@bergkvist
bergkvist merged commit 29a023f into main Apr 27, 2026
11 checks passed
@bergkvist
bergkvist deleted the tobias/rust-1.88 branch April 27, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants