-
Notifications
You must be signed in to change notification settings - Fork 63
Add JC2432W328C with CST820 driver #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Will review properly later; on the surface it looks fine. This however does not add it to both CI or the website, would that be preferred? |
Oh, didn't think about those. Yeah, let me know if you'd like me to add those and point me to the right place :) |
|
See /ci.py (list at the top of the file) and /_site/index.html (options within select) |
| "esp32-CROWPANEL-35C", | ||
| "esp32-JC2432W328C" | ||
| ] | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also an S3 chip, right?
|
I've added a new way to add devices to the .html (instead of manually editing the ci and html) Can you rebase this PR on the dev branch? |
Based on vvuk's pull request suchmememanyskill#193 from https://github.com/vvuk/CYD-Klipper/tree/jc2432w328c Added configuration to ci.json Fixed screen inverted Added support for screen rotation
|
The chip is no S3, it is a ESP32-D0WD-V3. As I wasn't able to contribute to this pull request I made a new pull request based on vvuk's code => #214 |
This board is a very cheap and decent 2.8" capacitive touchscreen board. With some trial and error, it's the same display as the CROWPANEL-28R, but using a CST820 I2C touch controller.
The board itself also has other smartdisplay features (RGB LED, SD card etc.) but they're not supported here yet (even if the esp_smartdisplay ifdefs are present).