Skip to content

[Aikido] AI Fix for A timing attack might allow hackers to bruteforce passwords #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suculent merged 1 commit into from
Dec 1, 2025
Merged

[Aikido] AI Fix for A timing attack might allow hackers to bruteforce passwords #507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/thinx/apikey.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
var Globals = require("./globals.js");
var AuditLog = require("./audit");
var sha256 = require("sha256");
const crypto = require('crypto');

const InfluxConnector = require('./influx');
module.exports = class APIKey {
Expand Down Expand Up @@ -77,7 +78,7 @@ module.exports = class APIKey {
let api_keys = JSON.parse(json_keys) || [];

for (let key in json_keys) {
if (key.key == new_api_key) {
if (key.key && crypto.timingSafeEqual(Buffer.from(key.key), Buffer.from(new_api_key))) {
return callback(false, "key_already_exists");
}
if (key.alias == apikey_alias) {
Expand Down
Loading