sudo_logsrvd: Don't close relay connection before ExitMessage written

When we are relaying a connection with no I/O logs we need to
be careful not to close the connection too early when relaying.
In this case, handle_exit() sets the state to FINISHED but the
last ClientMessage may not have been written yet.

Author: millert

logsrvd/logsrvd.c

@@ -1198,7 +1198,7 @@ client_msg_cb(int fd, int what, void *v)
     buf->len -= buf->off;
     buf->off = 0;
 
-    if (closure->state == FINISHED)
+    if (closure->state == FINISHED && closure->relay_closure == NULL)
 	goto close_connection;
 
     debug_return;

logsrvd/logsrvd_relay.c

@@ -1034,8 +1034,13 @@ relay_client_msg_cb(int fd, int what, void *v)
 	buf->len = 0;
 	TAILQ_REMOVE(&relay_closure->write_bufs, buf, entries);
 	TAILQ_INSERT_TAIL(&closure->free_bufs, buf, entries);
-	if (TAILQ_EMPTY(&relay_closure->write_bufs))
+	if (TAILQ_EMPTY(&relay_closure->write_bufs)) {
+	    /* Write queue empty, check state. */
 	    sudo_ev_del(closure->evbase, relay_closure->write_ev);
+	    if (closure->error || closure->state == FINISHED ||
+		    closure->state == SHUTDOWN)
+		goto close_connection;
+	}
     }
     debug_return;