sudoers: digest_matches: apply runchroot before open() #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move runchroot prefixing ahead of open() so the fd and path refer to the same file. Fixes false digest matches or mismatches when fd == -1 and runchroot != NULL, since sudo_filedigest reads from fd while messages use the path. Also reduces path confusion noted by the symlink/.. comment.
millert
approved these changes
Oct 17, 2025
Collaborator
millert
left a comment
millert
left a comment
There was a problem hiding this comment.
Looks good. This was a mis-merge when I added the runchroot path support back in.
Contributor
Author
|
out of interest, what is the consequence of this bug? |
Collaborator
|
If a sudoers rule specifies a hash for the command and there is a chroot dir specified (or the user is allowed to chroot to any dir), the hash would be computed based on the file outside the choot, not inside it. The chroot support is deprecated and scheduled to be removed in a future sudo release so I am not too concerned about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move runchroot prefixing ahead of open() so the fd and path refer to the same file. Fixes false digest matches or mismatches when fd == -1 and runchroot != NULL, since sudo_filedigest reads from fd while messages use the path. Also reduces path confusion noted by the symlink/.. comment.