parse_args.c never says "the -E option is not valid in edit mode" #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millert
reviewed
Dec 17, 2025
Collaborator
millert
left a comment
millert
left a comment
There was a problem hiding this comment.
Your fix is correct but this check will never succeed because of the
if ((flags & valid_flags) != flags)
usage();
above it. Can you move the valid flag test to be after the MODE_EDIT checks? That way the user will get a better error message.
Contributor
Author
Done |
This is because we are checking the wrong variable.
millert
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because we are checking the wrong variable.