fix: Correctly handle registry prefix #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When listing by prefix, this should ensure the `/` is added at the end,
otherwise URLs for subdomains, etc are also included in the results,
leading to finding multiple logins, when in reality only one exists.
As an example, logging in to Docker Hub via `docker login` results in
the following entries in the gopass store:
```
gopass
└── io.container.registries/
├── aHR0cHM6Ly9pbmRleC5kb2NrZXIuaW8vdjEv/
│ └── dGVzdHVzZXIK
├── aHR0cHM6Ly9pbmRleC5kb2NrZXIuaW8vdjEvYWNjZXNzLXRva2Vu/
│ └── dGVzdHVzZXIK
└── aHR0cHM6Ly9pbmRleC5kb2NrZXIuaW8vdjEvcmVmcmVzaC10b2tlbg==/
└── dGVzdHVzZXIK
```
Entries are created for:
https://index.docker.io/v1/
https://index.docker.io/v1/access-token
https://index.docker.io/v1/refresh-token%
When listing these are seen as multiple logins, where in reality they
are a single login (in the case above for `testuser`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When listing by prefix, this should ensure the
/is added at the end, otherwise URLs for subdomains, etc are also included in the results, leading to finding multiple logins, when in reality only one exists.As an example, logging in to Docker Hub via
docker loginresults in the following entries in the gopass store:Entries are created for:
https://index.docker.io/v1/
https://index.docker.io/v1/access-token
https://index.docker.io/v1/refresh-token
When listing these are seen as multiple logins, where in reality they are a single login (in the case above for
testuser).- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)