Increase Pexpect timeout and Systemd service file improvements for slow/bad networks#10
Open
cbmiller2610 wants to merge 2 commits intosudoofus:masterfrom
Open
Increase Pexpect timeout and Systemd service file improvements for slow/bad networks#10cbmiller2610 wants to merge 2 commits intosudoofus:masterfrom
cbmiller2610 wants to merge 2 commits intosudoofus:masterfrom
Conversation
Pexpect was timing out at boot, possibly due to slow wifi. if network is online this should be given a while to complete.
Reaching multi-user.target doesn't always guarantee the network successfully came up, so make it depend on network-online.target instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding some changes that are intended to add robustness to difficult network situations such as a very slow wifi network. It also seems that in order to not delay boot too much, some distros will not sit around and wait for network-online.target before reaching multi-user.target. So, cifstab would previously attempt to start upon reaching multi-user.target, but the network could still be down if things are slow.