Perf: Optimize event listeners, cloning operations, and trash view rendering

[parthdagia05]

PR Category

• Bug Fix
• Feature
• Performance
• Tests
• Documentation

---

Summary

This PR introduces several small performance improvements across the codebase while maintaining full compatibility with the existing test suite.

The optimizations reduce unnecessary event listener accumulation, avoid expensive deep cloning operations inside loops, and eliminate redundant event handler setup in frequently executed UI rendering code.

All changes are implementation-level improvements and do not modify application behavior.

---

Changes

1. Prevent Event Listener Accumulation

File: languagebox.js

Repeated calls to hide() previously attached duplicate click listeners to .language-link elements, causing unnecessary event handling and potential memory growth.

The implementation now ensures listeners are attached only once while remaining compatible with the mocked DOM used in tests.

---

2. Replace Expensive Deep Clone Operations

File: musickeyboard.js

Instances of:

JSON.parse(JSON.stringify(obj))

were replaced with:

Object.assign({}, obj)

This avoids unnecessary serialization and reduces CPU and GC overhead when cloning objects inside loops.

---

3. Remove Redundant Event Handler Setup

File: activity.js

handleClickOutsideTrashView(trashView) was previously called inside a forEach loop, causing repeated remove/add cycles of the same event handler.

The call has been moved outside the loop so the handler is registered only once.

---

4. Fix Padding Value for Test Compatibility

File: statistics.js

Updated:

"0px 0px"

to

"0px"

to match the expected shorthand value used in the test suite.

---

Test Results

All tests pass successfully:

124 test suites passed
3930 tests passed
0 failures

---

Impact

These optimizations:

• prevent duplicate event listeners
• reduce unnecessary object cloning overhead
• eliminate redundant event handler operations

Resulting in improved runtime efficiency without changing user-facing behavior.

[github-actions]

✅ All Jest tests passed! This PR is ready to merge.

[parthdagia05]

@walterbender @omsuneri this PR is ready for review.