test: add regression tests for turtle-singer note execution and counting behavior#6128
Open
mahesh-09-12 wants to merge 1 commit intosugarlabs:masterfrom
Open
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
@subhraneel2005 this PR continues the turtle-singer regression test work with a clean branch after closing the previous attempt that had unrelated commits during rebasing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR continues strengthening regression protection for the
turtle-singer.jsengine by adding focused tests for the note execution pipeline and note counting logic.A previous PR introduced regression tests covering lifecycle and pitch execution paths (
killAllVoices,numberOfNotes,processPitch).This PR extends that work by protecting additional execution behaviors related to note scheduling and counting.
This PR replaces #6113, which was closed to clean up commit history and remove unrelated changes introduced during rebasing.
No production code changes were made.
Covered Areas
1.
noteCounter()Adds regression tests protecting the internal counting mechanism used when evaluating note blocks.
Tests verify:
suppressOutputis restored correctlyjustCountingstack integrity2.
processNote()Adds regression tests protecting the core note execution entry point.
Tests verify:
3.
scalarDistance()Edge CasesAdds coverage for important edge cases including:
Impact
turtle-singer.jsPR Category