✨(frontend) improve accessibility of cdoc content with correct aria tags #1271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
force-pushed
the
fix/doc-content-head-access
branch
2 times, most recently
from
25d7248 to
c1cd0d1
Compare
Ovgodd
force-pushed
the
fix/doc-content-head-access
branch
from
c1cd0d1 to
0286a01
Compare
AntoLC
reviewed
Aug 8, 2025
src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx
Outdated
Show resolved
Hide resolved
Ovgodd
force-pushed
the
fix/doc-content-head-access
branch
3 times, most recently
from
36b367d to
1303bdb
Compare
added appropriate aria attributes and semantic tags to enhance accessibility Signed-off-by: Cyril <[email protected]>
Ovgodd
force-pushed
the
fix/doc-content-head-access
branch
from
1303bdb to
559b869
Compare
AntoLC
reviewed
Aug 12, 2025
Comment on lines
+442
to
+444
| await expect( | ||
| page.getByTestId('doc-open-modal-download-button'), | ||
| ).toBeVisible(); |
There was a problem hiding this comment.
Not needed, the click would not be possible if that was not already visible.
Suggested change
| await expect( | |
| page.getByTestId('doc-open-modal-download-button'), | |
| ).toBeVisible(); |
Comment on lines
+48
to
+51
| await page.waitForURL('**/docs/**', { | ||
| timeout: 10000, | ||
| waitUntil: 'domcontentloaded', | ||
| }); |
There was a problem hiding this comment.
It will increase test execution, if you need to increase time, better it increases the timeout, here you could do:
https://github.com/suitenumerique/docs/pull/1271/files#diff-1edbd2d2d1f16be04e52adef35ce6a7468b17d323b87999f0b636b99072404b4R54
await expect(input).toHaveText('', { timeout: 10000 });µ
Comment on lines
+75
to
+78
| await page.waitForURL('**/docs/**', { | ||
| timeout: 10000, | ||
| waitUntil: 'domcontentloaded', | ||
| }); |
| await expect(input).toBeVisible(); | ||
| await expect(input).toHaveText(''); | ||
| const input = page.locator('.--docs--doc-title-input[role="textbox"]'); | ||
| await expect(input).toBeVisible({ timeout: 20000 }); |
There was a problem hiding this comment.
Same it is not optimal, if it is a new doc the input should be empty, so assert with a bigger timeout on await expect(input).toHaveText(''); should make the job.
You could have the input visible, but still from a parent as it is now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Ensure that document content titles and download buttons are accessible to screen readers by using appropriate ARIA labels and adding missing translations.
Proposal