✨(frontend) set empty alt for decorative images in blocknote editor #1282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
force-pushed
the
fix/1073-alt-default-images
branch
from
4ec3212 to
9f90caa
Compare
ensure decorative images have empty alt to comply with RGAA 1.2 accessibility Signed-off-by: Cyril <[email protected]>
Ovgodd
force-pushed
the
fix/1073-alt-default-images
branch
from
9f90caa to
db361ad
Compare
AntoLC
approved these changes
Aug 12, 2025
Ovgodd
commented
Aug 12, 2025
There was a problem hiding this comment.
I like it this is clean just one little thing >
|
|
||
| export const accessibleImageRender = ( | ||
| block: BlockFromConfig<typeof imageBlockConfig, any, any>, | ||
| editor: BlockNoteEditor<any, any, any>, |
There was a problem hiding this comment.
Is there any related type we can use instead of any with BlockNote?
Or should we default to unknown for stricter typing? WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Ensure decorative images in the BlockNote editor have an empty alt attribute
by default to meet RGAA 1.2 accessibility requirements and improve
screenreader experience.
issue 1073
Proposal