Skip to content

Conversation

@AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Dec 9, 2025

Added

Changed

Fixed

@AntoLC AntoLC self-assigned this Dec 9, 2025
@AntoLC AntoLC added the release label Dec 9, 2025
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Size Change: +159 B (0%)

Total Size: 4.14 MB

Filename Size Change
apps/impress/out/_next/static/35a08fc0/_buildManifest.js 0 B -907 B (removed) 🏆
apps/impress/out/_next/static/48095f72/_buildManifest.js 904 B +904 B (new file) 🆕

compressed-size-action

Update translated files with new translations
When zooming in and out quickly, the editor
instance may not be fully mounted, leading to
errors when accessing its document. This commit
adds checks to ensure the editor and its view
are mounted before attempting to access the
document, preventing potential runtime errors.
When resizing the window and crossing the desktop
breakpoint, the editor was unmounted. It could
lead to loss of data if there were unsaved changes,
and tiptap crash if the toolbar was used while the
editor was unmounted.
It was caused by the ResizableLeftPanel component
which was rerendering the editor.
We now keep the editor mounted when resizing
the window, by keeping the ResizableLeftPanel
component rendered but setting its size to 0
and disabling the resize handle.
Added:
- ⚡️(frontend) export html

Changed:
- ♿(frontend) improve accessibility:
  - ♿(frontend) add skip to content button for keyboard
    accessibility
  - ♿(frontend) fix toggle panel button a11y labels
- 🔒️(frontend) remove dangerouslySetInnerHTML from codebase
- ⚡️(frontend) improve Comments feature

Fixed:
- 🐛(nginx) fix / location to handle new static pages
@AntoLC AntoLC linked an issue Dec 10, 2025 that may be closed by this pull request
@AntoLC AntoLC requested a review from Ovgodd December 10, 2025 11:24
Copy link
Collaborator

@Ovgodd Ovgodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice,

Just a small conditional extracted into a variable.

Comment on lines +99 to +101
if (!editor || !editor._tiptapEditor?.view?.dom) {
return;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!editor || !editor._tiptapEditor?.view?.dom) {
return;
}
const isEditorReady =
!!editor && !!editor._tiptapEditor?.view?.dom;
if (!isEditorReady) return;

Comment on lines +119 to +121
if (!editor || !editor._tiptapEditor?.view?.dom) {
return;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!editor || !editor._tiptapEditor?.view?.dom) {
return;
}
```suggestion
const isEditorReady =
!!editor && !!editor._tiptapEditor?.view?.dom;
if (!isEditorReady) return;

Comment on lines +32 to +34
if (!editor || !editor._tiptapEditor?.view?.dom) {
return;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!editor || !editor._tiptapEditor?.view?.dom) {
return;
}
```suggestion
const isEditorReady =
!!editor && !!editor._tiptapEditor?.view?.dom;
if (!isEditorReady) return;

@AntoLC AntoLC merged commit 12cc79b into main Dec 10, 2025
37 of 38 checks passed
@AntoLC AntoLC deleted the release/4.1.0 branch December 10, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected refresh

4 participants