-
Notifications
You must be signed in to change notification settings - Fork 471
🔖(minor) release 4.1.0 #1715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔖(minor) release 4.1.0 #1715
Conversation
|
Size Change: +159 B (0%) Total Size: 4.14 MB
|
Update translated files with new translations
f218b8f to
6b36763
Compare
When zooming in and out quickly, the editor instance may not be fully mounted, leading to errors when accessing its document. This commit adds checks to ensure the editor and its view are mounted before attempting to access the document, preventing potential runtime errors.
When resizing the window and crossing the desktop breakpoint, the editor was unmounted. It could lead to loss of data if there were unsaved changes, and tiptap crash if the toolbar was used while the editor was unmounted. It was caused by the ResizableLeftPanel component which was rerendering the editor. We now keep the editor mounted when resizing the window, by keeping the ResizableLeftPanel component rendered but setting its size to 0 and disabling the resize handle.
Added:
- ⚡️(frontend) export html
Changed:
- ♿(frontend) improve accessibility:
- ♿(frontend) add skip to content button for keyboard
accessibility
- ♿(frontend) fix toggle panel button a11y labels
- 🔒️(frontend) remove dangerouslySetInnerHTML from codebase
- ⚡️(frontend) improve Comments feature
Fixed:
- 🐛(nginx) fix / location to handle new static pages
6b36763 to
12cc79b
Compare
Ovgodd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice,
Just a small conditional extracted into a variable.
| if (!editor || !editor._tiptapEditor?.view?.dom) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if (!editor || !editor._tiptapEditor?.view?.dom) { | |
| return; | |
| } | |
| const isEditorReady = | |
| !!editor && !!editor._tiptapEditor?.view?.dom; | |
| if (!isEditorReady) return; |
| if (!editor || !editor._tiptapEditor?.view?.dom) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if (!editor || !editor._tiptapEditor?.view?.dom) { | |
| return; | |
| } | |
| ```suggestion | |
| const isEditorReady = | |
| !!editor && !!editor._tiptapEditor?.view?.dom; | |
| if (!isEditorReady) return; |
| if (!editor || !editor._tiptapEditor?.view?.dom) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if (!editor || !editor._tiptapEditor?.view?.dom) { | |
| return; | |
| } | |
| ```suggestion | |
| const isEditorReady = | |
| !!editor && !!editor._tiptapEditor?.view?.dom; | |
| if (!isEditorReady) return; |
Added
Changed
Fixed