Open
Conversation
AntoLC
force-pushed
the
feat/move-doc-modal
branch
2 times, most recently
from
cd7a395 to
f83adbd
Compare
|
Size Change: +1.9 kB (+0.05%) Total Size: 4.22 MB
|
AntoLC
force-pushed
the
feat/move-doc-modal
branch
from
f83adbd to
c421d9f
Compare
AntoLC
force-pushed
the
feat/move-doc-modal
branch
from
c421d9f to
56d9bf5
Compare
|
🚀 Preview will be available at https://1886-docs.ppr-docs.beta.numerique.gouv.fr/ You can use the existing account with these credentials:
You can also create a new account if you want to. Once this Pull Request is merged, the preview will be destroyed. |
AntoLC
force-pushed
the
feat/move-doc-modal
branch
3 times, most recently
from
03e3d26 to
f7093b5
Compare
AntoLC
force-pushed
the
feat/move-doc-modal
branch
from
f7093b5 to
cce4870
Compare
Ovgodd
requested changes
Feb 25, 2026
Collaborator
Ovgodd
left a comment
Ovgodd
left a comment
There was a problem hiding this comment.
Nice feature! Just a few accessibility improvements to consider.
src/frontend/apps/impress/src/features/docs/docs-grid/components/DocMoveModal.tsx
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-share/components/AlertModalRequestAccess.tsx
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/docs-grid/components/DocMoveModal.tsx
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-share/components/AlertModalRequestAccess.tsx
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-share/components/AlertModalRequestAccess.tsx
Show resolved
Hide resolved
To keep consistency with the other modals, we move the share modal directly to the DocsGridActions component. This way, we avoid having to pass down the openShareModal function from parent components and keep the logic related to sharing a doc encapsulated within the concern component.
We could drag and drop the items even if the modal was opened, which could cause some unexpected behaviors. This commit disables the DND functionality when a dialog box is open.
We can now move a doc to another doc from a search modal. It will make it easier to move a doc without having to scroll through the doc grid to find the destination doc. We kept most of the logic implemented in the doc grid dnd.
If the document has more than 1 direct access,we want to display a confirmation modal before moving the document. This is to prevent users from accidentally moving a document that is shared with multiple people. The accesses and invitations will be removed from the document.
If a user tries to move a document for which they don't have the right to move, we now display a modal to request access to the owners of the document.
AntoLC
force-pushed
the
feat/move-doc-modal
branch
from
cce4870 to
c0d3ac7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
It is not every time easy to move document from the grid with the drag and drop.
We added a search modal to move document.
Proposal
Demo
Enregistrement.2026-02-20.173818.mp4