♻️(front) improve table pdf rendering #639
Conversation
NathanVss
force-pushed
the
fix/pdf-render
branch
3 times, most recently
from
65a3137 to
779e3c9
Compare
|
Wow, this is cool ! |
AntoLC
left a comment
AntoLC
left a comment
There was a problem hiding this comment.
It's cool ^^
Let's see this yarn.lock and let's go 🚀
There was a problem hiding this comment.
I got lot of diff when I try the branch. I think the yarn.lock is not totally updated (rebase ?)
src/frontend/apps/impress/src/features/docs/doc-header/components/ModalExport.tsx
Outdated
Show resolved
Hide resolved
| <TH key={index}> | ||
| {row.cells.map((cell, index) => { | ||
| return ( | ||
| <TD key={index}> |
There was a problem hiding this comment.
I have a few warning about identical key, maybe it can be fix easily ?
|
It could be nice to have it integrated by default in Blocknotes wdyt @YousefED ? |
NathanVss
force-pushed
the
fix/pdf-render
branch
from
779e3c9 to
056fca9
Compare
Cool! Great to see this. I'd be happy to add this to react-pdf. @NathanVss are you able to do this? Otherwise we add it to our todos I see two ways: |
The previous way of rendering table was causing issues when tables could not fit on one page. I then came accross this discussion diegomura/react-pdf#2343. The author created a lib to improve the rendering of table, it's better, but still not perfect maybe.
NathanVss
force-pushed
the
fix/pdf-render
branch
from
f52d279 to
9a5852d
Compare
|
@NathanVss I was wrong in standup, react-pdf depends on pdfkit, not pdfjs For pdfkit, this issue is in progress: foliojs/pdfkit#1577 Once that lands it should be possible to add it to react-pdf and then to blocknote / docs |
Purpose
The previous way of rendering table was causing issues when tables could not fit on one page. I then came accross this discussion diegomura/react-pdf#2343. The author created a lib to improve the rendering of table, it's better, but still not perfect maybe.
Proposal
The Doc
Before
After