🚸(email) we should ignore case when looking for existing emails #1056
+53
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qbey
force-pushed
the
qbey/email-ignore-case
branch
from
53250b6 to
29c62db
Compare
mjeammet
reviewed
Feb 11, 2026
Comment on lines
62
to
64
| # Try with mixed case - should also fail | ||
| with pytest.raises(EmailAlreadyKnownException): | ||
| factories.InvitationFactory(email="[email protected]") |
Member
There was a problem hiding this comment.
you swapped the comments / the actual tests
mjeammet
reviewed
Feb 11, 2026
CHANGELOG.md
Outdated
|
|
||
| - 🏗️(core) migrate from pip to uv | ||
| - ✨(front) add show invitations mails domains access #1040 | ||
| - 🚸(email) we should ignore case when looking for existing emails #1056 |
Member
There was a problem hiding this comment.
Probably not very important but I realize you add more recent changelog lines below existing lines when I add them above.
mjeammet
approved these changes
Feb 11, 2026
Our products mostly rely on email regardless of their case. Next step would be to normalize email to lower case when storing them in database (or sending them to dimail if not done yet).
qbey
force-pushed
the
qbey/email-ignore-case
branch
from
39a7723 to
aaa9b27
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Our products mostly rely on email regardless of their case.
Next step would be to normalize email to lower case when storing them in database (or sending them to dimail if not done yet).
Proposal