Conversation
The test_get_or_create test uses Thread.join which can hang on Windows, causing CI tests to run indefinitely. This test creates 30 threads to test concurrent cache access. On Windows with certain Ruby versions (observed with 3.3.10), Thread.join appears to hang or take an extremely long time. Skip this test on Windows platforms (mingw, mswin, cygwin) to prevent CI timeouts.
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
The
test_get_or_createtest ininstance_cache_test.rbhangs on Windows, causing CI tests to run for 40+ minutes without completing. This test creates 30 threads to test concurrent cache access.On Windows with certain Ruby versions (observed with Ruby 3.3.10),
Thread.joinappears to hang or take an extremely long time to complete.Root Cause
The test on line 14-21 runs:
This is the likely cause of the Windows CI hanging issue.
Solution
Skip this test on Windows platforms using:
Impact
Testing
Fixes the root cause of hanging Windows CI tests.