Skip to content

[WIP] enable Committee::Middleware::ResponseValidation#2452

Draft
jmartin-sul wants to merge 1 commit intomainfrom
response-validation
Draft

[WIP] enable Committee::Middleware::ResponseValidation#2452
jmartin-sul wants to merge 1 commit intomainfrom
response-validation

Conversation

@jmartin-sul
Copy link
Member

Why was this change made? 🤔

closes #1407

this probably has to stay WIP/draft until interagent/committee#300 is fixed.

when revisiting this, also consider the suggestion from @justinlittman on the pres cat ticket: #1407 (comment)

For what it is worth, I believe that for other apps, we only do response validation during tests.
See https://github.com/sul-dlss/dor-services-app/blob/fe8a3a024571092b2e0d8290a90f36f8aa69a285/config/application.rb#L61-L72

How was this change tested? 🤨

⚡ ⚠ If this change has cross service impact, or if it changes code used internally for cloud replication, run integration test preassembly_reaccessioning_spec.rb against stage, as it tests preservation (including cloud replication), and/or test manually in stage environment, in addition to specs.

The main classes relevant to replication are ZipmakerJob, DeliveryDispatcherJob, *DeliveryJob, ResultsRecorderJob, and DruidVersionZip; see here for overview diagram of replication pipeline.⚡

Does your change introduce accessibility violations? 🩺

⚡ ⚠ Please ensure this change does not introduce accessibility violations (at the WCAG A or AA conformance levels); if it does, include a rationale. See the Infrastructure accessibility guide for more detail. ⚡

properties:
id:
type: integer
example: 123
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't actually get returned in the response, and i don't think consumers are actually looking for it (because it's just the internal DB PK, but everything does lookup and matching by druid in other systems)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable response validation per OpenAPI spec

1 participant