[WIP] enable Committee::Middleware::ResponseValidation#2452
Draft
jmartin-sul wants to merge 1 commit intomainfrom
Draft
[WIP] enable Committee::Middleware::ResponseValidation#2452jmartin-sul wants to merge 1 commit intomainfrom
jmartin-sul wants to merge 1 commit intomainfrom
Conversation
jmartin-sul
commented
Jul 30, 2025
| properties: | ||
| id: | ||
| type: integer | ||
| example: 123 |
Member
Author
There was a problem hiding this comment.
this doesn't actually get returned in the response, and i don't think consumers are actually looking for it (because it's just the internal DB PK, but everything does lookup and matching by druid in other systems)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why was this change made? 🤔
closes #1407
this probably has to stay WIP/draft until interagent/committee#300 is fixed.
when revisiting this, also consider the suggestion from @justinlittman on the pres cat ticket: #1407 (comment)
How was this change tested? 🤨
⚡ ⚠ If this change has cross service impact, or if it changes code used internally for cloud replication, run integration test preassembly_reaccessioning_spec.rb against stage, as it tests preservation (including cloud replication), and/or test manually in stage environment, in addition to specs.
The main classes relevant to replication are
ZipmakerJob,DeliveryDispatcherJob,*DeliveryJob,ResultsRecorderJob, andDruidVersionZip; see here for overview diagram of replication pipeline.⚡Does your change introduce accessibility violations? 🩺
⚡ ⚠ Please ensure this change does not introduce accessibility violations (at the WCAG A or AA conformance levels); if it does, include a rationale. See the Infrastructure accessibility guide for more detail. ⚡