Open
Conversation
mjgiarlo
force-pushed
the
refactor-dvz-dvzp#2519
branch
from
4d2feca to
82be245
Compare
Contributor
justinlittman
left a comment
justinlittman
left a comment
There was a problem hiding this comment.
This is a huge improvement. The naming seems fine to me.
Only significant recommendations are:
- Add additional documentation to classes / initializers.
- Consider class-specific errors instead of generic / StandardError.
mjgiarlo
force-pushed
the
refactor-dvz-dvzp#2519
branch
from
82be245 to
771f736
Compare
mjgiarlo
force-pushed
the
refactor-dvz-dvzp#2519
branch
3 times, most recently
from
8d56edd to
e11579e
Compare
mjgiarlo
force-pushed
the
refactor-dvz-dvzp#2519
branch
from
e11579e to
bd4bd18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why was this change made?
Fixes #2519
app/services/TO-DO
How was this change tested?
CI