Sourcery refactored master branch

[sourcery-ai]

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[sourcery-ai]

Function plot_log refactored with the following changes:

• Replaces an empty collection equality with a boolean operation (simplify-empty-collection-comparison)
• Replace a for append loop with list extend (for-append-to-extend)
• Simplify logical expression using De Morgan identities (de-morgan)

[sourcery-ai]

Function Mask.compute_output_shape refactored with the following changes:

• Unwrap a constant iterable constructor [×2] (unwrap-iterable-construction)

[sourcery-ai]

Function CapsuleLayer.compute_output_shape refactored with the following changes:

• Unwrap a constant iterable constructor (unwrap-iterable-construction)

[sourcery-ai]

Function train refactored with the following changes:

• Use f-string instead of string concatenation [×5] (use-fstring-for-concatenation)

[sourcery-ai]

Lines 574-611 refactored with the following changes:

• Move assignment closer to its usage within a block (move-assign-in-block)
• Use named expression to simplify assignment and conditional (use-named-expression)

This removes the following comments ( why? ):

# as long as weights are given, will run testing
# valid(model=eval_model, data=(x_valid))

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.41%.

Quality metrics	Before	After	Change
Complexity	5.43 ⭐	5.14 ⭐	-0.29 👍
Method Length	111.75 🙂	111.62 🙂	-0.13 👍
Working memory	6.33 🙂	6.18 ⭐	-0.15 👍
Quality	56.39% 🙂	56.80% 🙂	0.41% 👍

Other metrics	Before	After	Change
Lines	546	548	2

Changed files	Quality Before	Quality After	Quality Change
CapsNet_Cifer10.py	56.39% 🙂	56.80% 🙂	0.41% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
CapsNet_Cifer10.py	load_catdog	9 🙂	320 ⛔		41.13% 😞	Try splitting into smaller methods
CapsNet_Cifer10.py	plot_log	14 🙂	237 ⛔	10 😞	42.75% 😞	Try splitting into smaller methods. Extract out complex expressions
CapsNet_Cifer10.py	load_cifer10	5 ⭐	239 ⛔		51.75% 🙂	Try splitting into smaller methods
CapsNet_Cifer10.py	train	2 ⭐	279 ⛔		53.36% 🙂	Try splitting into smaller methods
CapsNet_Cifer10.py	CapsNet	0 ⭐	220 ⛔	10 😞	57.01% 🙂	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!