Add more io_uring ZCRX definitions #158
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanshade
force-pushed
the
io_uring-zcrx
branch
from
211c145 to
91447bc
Compare
|
@sunfishcode I think this should be ready for review now. There might be some additional changes needed here to enable zcrx (see my comment) but I can't actually test that right now anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: bytecodealliance/rustix#1485
Submitting this as a draft until the
rustixandrustix-uringPRs are ready.Note that I changed
IORING_ZCRX_AREA_SHIFTto au64. I believe this is how it should be judging from its use in liburing for setting the rqe offset and for computingIORING_ZCRX_AREA_MASK.CC @LtdJorge