Skip to content

Fix .type directive syntax for ARM targets #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
walruscraft wants to merge 1 commit into from
Closed

Fix .type directive syntax for ARM targets #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion src/naked.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,10 @@ macro_rules! naked_fn {
/// `#[naked]` is nightly-only. We use it when we can, and fall back to
/// `global_asm` otherwise. This macro supports a limited subset of the
/// features of `#[naked]`.
Copy link
Contributor

@bjorn3 bjorn3 Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#[naked] is now available on stable.

#[cfg(not(feature = "nightly"))]
///
/// Note: ARM targets use `%function` syntax for the .type directive,
/// while other targets use `@function`.
#[cfg(all(not(feature = "nightly"), not(target_arch = "arm")))]
macro_rules! naked_fn {
(
$doc:literal;
Expand All @@ -76,3 +79,27 @@ macro_rules! naked_fn {
);
};
}

/// ARM variant using `%function` syntax.
#[cfg(all(not(feature = "nightly"), target_arch = "arm"))]
macro_rules! naked_fn {
(
$doc:literal;
$vis:vis fn $name:ident $args:tt -> $ret:ty;
$($code:literal),*;
$($label:ident = $kind:ident $path:path),*
) => {
unsafe extern "C" {
#[doc = $doc]
$vis fn $name $args -> $ret;
}
core::arch::global_asm!(
concat!(".global ", stringify!($name)),
concat!(".type ", stringify!($name), ", %function"),
concat!(stringify!($name), ":"),
$($code),*,
concat!(".size ", stringify!($name), ", .-", stringify!($name)),
$($label = $kind $path),*
);
};
}