Use stable #[naked] instead of global_asm!() fallback #169
+193
−275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Jan 12, 2026
src/naked.rs
Outdated
| #[cfg(feature = "nightly")] | ||
| /// Wrapper around `#[naked]` for defining naked functions. | ||
| /// This macro supports a limited subset of `#[naked]` features. | ||
| macro_rules! naked_fn { |
Contributor
There was a problem hiding this comment.
This macro can be inlined now.
#[naked] is stable since Rust 1.79, and origin already requires 1.88. This removes the global_asm!() fallback and the naked_fn! macro entirely, inlining #[naked] directly at each call site.
vak-leon
force-pushed
the
use-stable-naked
branch
from
a87bd39 to
ff706cd
Compare
bjorn3
reviewed
Jan 12, 2026
| __NR_rt_sigreturn = const __NR_rt_sigreturn | ||
| ); | ||
| #[unsafe(naked)] | ||
| #[unsafe(no_mangle)] |
Contributor
There was a problem hiding this comment.
Does this actually need to be no_mangle?
|
|
||
| #[unsafe(naked)] | ||
| #[unsafe(no_mangle)] | ||
| pub(super) unsafe extern "C" fn _start() -> ! { |
Contributor
There was a problem hiding this comment.
extern "custom" would make sense here, but that isn't stable yet and it is not worth it to keep the macro just for that IMHO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
#[naked]is stable now (1.79) and origin already requires 1.88, we can drop theglobal_asm!()fallback entirely.This sidesteps the whole
@functionvs%functionplatform-specific syntax mess that #168 was trying to fix.Per @bjorn3's suggestion - this supersedes #168.