Skip to content

Improve the base type analyzer, making it more explicit #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sunnamed434 merged 4 commits into from
Sep 29, 2025
Merged

Improve the base type analyzer, making it more explicit #243

sunnamed434 merged 4 commits into from
Sep 29, 2025

Conversation

@Bip901
Copy link
Contributor

@Bip901 Bip901 commented Sep 24, 2025

Changes

  1. CriticalBaseTypesCriticalAnalyzer currently only takes into account the immediate parent. This change considers the entire inheritance chain.
  2. The analyzer now takes into account the namespace as well, by using FullName rather than Name, so you can now be exact in the types you specify
  3. CriticalBaseTypes are now specified via glob patterns (e.g. "RocketPlugin*"), rather than the implicit "StartsWith", which allows matching exact class names by dropping the "*".

sunnamed434
sunnamed434 approved these changes Sep 25, 2025
View reviewed changes
Copy link
Owner

@sunnamed434 sunnamed434 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunnamed434 sunnamed434 merged commit 488ade7 into sunnamed434:main Sep 29, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunnamed434 sunnamed434 sunnamed434 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bip901 @sunnamed434