Draft
Conversation
added 10 commits
May 30, 2022 21:47
switch index.css to scss to use breakpoint
changes for font sizing and spacing for mobile
i thought about how to adapt the existing desktop Initiative interface to work on mobile. i came to the conclusion that the spreadsheet UI wouldn't work for mobile, so i went with a card-based approach. it's not complete, the cards aren't editable, but it's an okay starting point for the layout. not sure about the add button color
adds spring transitions to items lower than the newly expanded one, so they'll slide down. also adds scrolling so the screen will auto scroll and the newly expanded item will be at the top
mobile can use `window.scrollTo`, but desktop has `overflow: scroll` on the containg section element, so the container has to be scrolled
tweaked the timing a little, added some delay to the slide. i can already tell this is going to require a lot of tweaking to get right, but it's worth it
initial steps towards generalizing the expanding/sliding/transitions for a list. currently working out the kinks as i'm implementing it in Creatures, but the idea is that this will be usable for Creatures, Items, and future modules (Spells)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR is a work in progress, just making the PR to get it to deploy