All ruff experiment #774
All ruff experiment #774
Conversation
| factor = np.asarray(factor) | ||
| new_grids = [] | ||
| for c, d, f in zip(offset, cube_shape, factor): | ||
| for c, d, f in zip(offset, cube_shape, factor, strict=False): |
There was a problem hiding this comment.
I hate this isn't set to true automatically.
|
I did not expect that like 90% of the auto changes are just double quotes. |
|
The output from ruff was so much it had to be truncated. Let me run it locally and paste the output here. |
It is expensive |
|
The full output from ruff is over 4000 lines. I would say the vast majority fall under: SLF001 Private member accessed We can skip these for test files for sure. |
|
The changes needed to fix this aren't hard, but it will take a while and it's boring. |
It is expensive
Preach, I'm not sure how else we could do this though? |
Either we wait for ruff to autofix them, or someone has to fix it. |
|
I am much more in favour of picking our lints carefully than doing this fwiw. |
|
Closing in favor of #773 |
3 participants
No description provided.