-
-
Notifications
You must be signed in to change notification settings - Fork 54
Reduce memory consuption in axis_world_coords (again) #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR needs tests which test at least with some DKIST or IRIS WCSes that you can get low-memory axis world coords for uncorrelated axes, and as a counterpoint that correlated axes still work properly. For example, I have tested that |
|
I do question why I bother to do any programming if its always wrong. This solution works: Command line: /home/nabil/.mamba/envs/iris-dev/bin/memray run -f -o output.bin examples/umbral_flashes.py The biggest allocations are from loading the data: |
|
This is great news! |
|
@nabobalis I can't add a visp WCS without a |
I am the same |
|
Could we try Wills WCS from his issue? |
deee62c to
72d8859
Compare
|
|
||
|
|
||
| @pytest.fixture | ||
| def ndcube_3d_coupled(wcs_3d_ln_lt_l_coupled): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is good.
ae8bac4 to
e15bc13
Compare
17ec1ec to
ff9db90
Compare
ff9db90 to
c440645
Compare
|
I would be nice to get a test which tests the 2D usecase. |
|
How does one do that? |
c440645 to
324413f
Compare
If the pixel axes are not correlated with a requested world axis then don't generate the coords in the mesh
eb2cca2 to
71c7e86
Compare
71c7e86 to
1a5bd72
Compare

This PR works, as an alternative to #780 by not generating mesh coords for unneeded pixel axes.
i.e. if the pixel axes are not correlated with a requested world axis then don't generate the coords in the mesh.