Skip to content

Conversation

@Cadair
Copy link
Member

@Cadair Cadair commented Oct 7, 2025

This PR has been generated by a script, it should update the repo with the latest changes from the package template.

@nabobalis nabobalis added this to the 2.4.0 milestone Oct 8, 2025
@nabobalis
Copy link
Member

Oldestdeps is failing on:

===================================================================================== FAILURES =====================================================================================
_______________________________________________________________________________ test_plot_docstring ________________________________________________________________________________
[gw2] linux -- Python 3.12.11 /home/runner/work/ndcube/ndcube/.tox/py312-oldestdeps/bin/python

self = <ndcube.visualization.descriptor.PlotterDescriptor object at 0x7f3fc50525d0>, raise_error = True

    def _resolve_default_type(self, raise_error=True):
        # We special case the default MatplotlibPlotter so that we can
        # delay the import of matplotlib until the plotter is first
        # accessed.
        if self._default_type in ("mpl_plotter", "mpl_sequence_plotter"):
            if self._default_type == "mpl_plotter":
                try:
>                   from ndcube.visualization.mpl_plotter import MatplotlibPlotter  # noqa: PLC0415
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

../../.tox/py312-oldestdeps/lib/python3.12/site-packages/ndcube/visualization/descriptor.py:38: 

pyproject.toml Outdated
name = "ndcube"
description = "A package for multi-dimensional contiguous and non-contiguous coordinate aware arrays."
requires-python = ">=3.10"
requires-python = ">=3.12"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would people feel about keeping this at 3.11 for one more major release? I'd kinda like to get the ASDF stuff out and not immediately have to bump dkist to 3.12.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong view

@Cadair
Copy link
Member Author

Cadair commented Oct 8, 2025

Oldestdeps is failing on:

It's failing because old matplotlib wasn't getting installed, and new mpl was incompatible with old astropy. Now fixed.

Co-authored-by: Nabil Freij <[email protected]>
@Cadair Cadair force-pushed the cruft-manual-update branch from 7fc1406 to daf30b5 Compare October 8, 2025 16:55
@Cadair
Copy link
Member Author

Cadair commented Oct 8, 2025

pre-commit.ci autofix

tests
commands_pre =
oldestdeps: minimum_dependencies ndcube --filename requirements-min.txt
oldestdeps: minimum_dependencies ndcube --extras plotting reproject tests-optional --filename requirements-min.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure we do this for packages in the future.

@DanRyanIrish DanRyanIrish merged commit 71984db into sunpy:main Oct 9, 2025
21 checks passed
@Cadair Cadair deleted the cruft-manual-update branch October 9, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants