-
-
Notifications
You must be signed in to change notification settings - Fork 54
Updates from package template #889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated minimum version requirements for Python, NumPy, SciPy, and astropy.
Updated gwcs dependency version from 0.18 to 0.19.0.
|
Oldestdeps is failing on: |
pyproject.toml
Outdated
| name = "ndcube" | ||
| description = "A package for multi-dimensional contiguous and non-contiguous coordinate aware arrays." | ||
| requires-python = ">=3.10" | ||
| requires-python = ">=3.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would people feel about keeping this at 3.11 for one more major release? I'd kinda like to get the ASDF stuff out and not immediately have to bump dkist to 3.12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no strong view
It's failing because old matplotlib wasn't getting installed, and new mpl was incompatible with old astropy. Now fixed. |
Co-authored-by: Nabil Freij <[email protected]>
7fc1406 to
daf30b5
Compare
|
pre-commit.ci autofix |
| tests | ||
| commands_pre = | ||
| oldestdeps: minimum_dependencies ndcube --filename requirements-min.txt | ||
| oldestdeps: minimum_dependencies ndcube --extras plotting reproject tests-optional --filename requirements-min.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make sure we do this for packages in the future.
for more information, see https://pre-commit.ci
This PR has been generated by a script, it should update the repo with the latest changes from the package template.