Migrate network clients to new unified Scraper format (Fix #113)#142
Open
Amityush-lgtm wants to merge 8 commits intosunpy:mainfrom
Open
Migrate network clients to new unified Scraper format (Fix #113)#142Amityush-lgtm wants to merge 8 commits intosunpy:mainfrom
Amityush-lgtm wants to merge 8 commits intosunpy:mainfrom
Conversation
added 8 commits
February 9, 2026 23:12
Author
|
All the CI Checks are green now. The PR is ready for review now @samaloney. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Migrate network clients to unified Scraper format. Fixes: #113
Summary
This PR updates all
radiospectranetwork clients (RSTN, eCallisto, I-LOFAR, and PSP) to use the modern, unifiedsunpy.net.scraper.Scraperinterface introduced in SunPy 6.1 and enforced in 7.1.0.It fixes CI failures caused by breaking changes in SunPy 7.1.0 and brings the networking code in line with current SunPy standards. This PR restores compatibility and modernizes the implementation to match current SunPy expectations.
What changed
baseurl+patternusage with a single modernpatternstring using the{{ }}format required byScraper.Scraper’s internal.format()handling.KeyErrorby aligning pattern capture groups with metadata usage.search()andpre_search_hook()implementations to match the updatedScraperAPI.Verification
test_ecallisto_client✅test_rstn_client✅test_ilofar✅test_psp_client✅Reviewer:
@samaloney, Please let me know if this change looks good to you or if you’d like any revisions.