Fix #110: Ensure spectrogram plotting correctly handles non-UTC time scales#144
Open
Amityush-lgtm wants to merge 3 commits intosunpy:mainfrom
Open
Fix #110: Ensure spectrogram plotting correctly handles non-UTC time scales#144Amityush-lgtm wants to merge 3 commits intosunpy:mainfrom
Amityush-lgtm wants to merge 3 commits intosunpy:mainfrom
Conversation
Amityush-lgtm
force-pushed
the
fix-cdf-time-scale
branch
from
36a89e4 to
7da7edd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Fixes an issue where plotting data with different time scales i.e. 'tt' and 'utc' would result in time offsets because
GenericSpectrogramplotting was using the raw time scale components directly via.datetime. Corrects the plotting logic to always convert to UTC first.Closes #110
What changed
radiospectra/mixins.pyto ensureself.timesis converted to UTC before generatingdatetimeobjects for plotting._times_utc_datetimeto handle the conversion if supported by the time object.@samaloney, Let me know your thoughts on this!!