Fix #56: Correct Callisto client and observatory fallback#145
Open
Monier-Ayman wants to merge 13 commits intosunpy:mainfrom
Open
Fix #56: Correct Callisto client and observatory fallback#145Monier-Ayman wants to merge 13 commits intosunpy:mainfrom
Monier-Ayman wants to merge 13 commits intosunpy:mainfrom
Conversation
Author
|
@samaloney Hi! I’ve made the changes for PR #145 to fix bug #56 and standardize the eCALLISTO client and observatory fallback. Could you please take a look when you have a chance and let me know if everything looks good or if you have any feedback? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes bug #56 where the Callisto client and attribute names were inconsistent (
CallistovseCallisto).Changes made
observatoryfield to use"e-CALLISTO"ifINSTRUMEis missing in the FITS header.post_search_hookto ensureObservatoryis always set to"e-CALLISTO"if missing.Testing
INSTRUMEvalues.eCALLISTOClientreturns the correct"Observatory"field in search results.This ensures consistent naming and correct behavior when working with eCallisto files in
radiospectra.