Fix Spectrum slicing to preserve freq_axis metadata#146
Open
vishwas-droid wants to merge 2 commits intosunpy:mainfrom
Open
Fix Spectrum slicing to preserve freq_axis metadata#146vishwas-droid wants to merge 2 commits intosunpy:mainfrom
vishwas-droid wants to merge 2 commits intosunpy:mainfrom
Conversation
a0d0e73 to
1997da4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where slicing a
Spectrumobject could result in incorrector inconsistent propagation of its associated
freq_axismetadata.Since
Spectrumsubclassesnumpy.ndarray, slicing operations return new views.Without explicitly handling NumPy subclass mechanics, custom attributes such as
freq_axismay not always be reliably preserved.Changes
__array_finalize__to properly propagate metadata when new views are created.__getitem__to ensure slicedSpectrumobjects retain a correctly slicedfreq_axis.Behavior After This PR
spec[2:5])spec[spec > 5])spec[[1, 3, 5]])spec + 5)All correctly preserve
freq_axis.Backward Compatibility
No breaking changes. Existing tests pass and behavior remains consistent for all supported use cases.