fix: emit whitespace changes after all #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juleswritescode
approved these changes
Mar 12, 2025
Collaborator
juleswritescode
left a comment
juleswritescode
left a comment
There was a problem hiding this comment.
I highly doubt that you're a big idiot, you're not even 1.90m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after some forth and back yesterday and a crash when starting to complete after a change I realised I am big idiot because not emitting whitespaces will result in an invalid tree sitter tree… 🥲 so yeah, we just emit them now. also added an e2e test for completions.
also