feat: add dblint with splinter #631
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juleswritescode
approved these changes
Jan 2, 2026
Comment on lines
+197
to
+212
| if !has_only_filter { | ||
| let enabled_rules = self | ||
| .settings | ||
| .as_splinter_rules() | ||
| .map(|rules| rules.as_enabled_rules()) | ||
| .unwrap_or_default(); | ||
|
|
||
| self.enabled_rules.extend(enabled_rules); | ||
|
|
||
| let disabled_rules = self | ||
| .settings | ||
| .as_splinter_rules() | ||
| .map(|rules| rules.as_disabled_rules()) | ||
| .unwrap_or_default(); | ||
| self.disabled_rules.extend(disabled_rules); | ||
| } |
Collaborator
There was a problem hiding this comment.
this seems very familiar, is this an opportunity to dedupe some code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as simple as it gets for now.
will wire up pglinter next and then check if we can refactor linters to share even more
fixed the generated documentation too, which makes up for most of the changes.