feat(dblint): add pglinter #632
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteinroe
force-pushed
the
feat/splinter
branch
from
ce64a8b to
322df77
Compare
- Add #![cfg(not(target_os = "windows"))] to skip pglinter tests on Windows since the pglinter extension is not available there (only Linux/macOS) - Fix clippy warnings: use as_deref() and contains() instead of manual patterns - Remove table_with_primary_key test since pglinter checks all tables globally, making a "no diagnostics for table with PK" test impossible when other tables exist - Add plpgsql_check as dependency in test setup 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
juleswritescode
approved these changes
Jan 9, 2026
| # Verify installation | ||
| echo "Extension control files:" | ||
| ls -la "$(pg_config --sharedir)/extension/" | grep pglinter || echo "No pglinter found" |
Collaborator
There was a problem hiding this comment.
should we fail early here? right now this would be cachted after creating extension plpgsql_check, if I'm not mistaken
| let mut runnable_rules = Vec::new(); | ||
| for rule_code in &enabled_rules { | ||
| if disabled_in_extension.contains(rule_code) { | ||
| results.push(PglinterDiagnostic::rule_disabled_in_extension(rule_code)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for
pglinterand integrate it withdblint. It reuses the existing infrastructure, and 99% of the code changes are generated.adapted the
Dockerfileto also installpglinter. Will take around 10 minutes now to build, but its all cached after that.the initial metadata is generated from the downloaded repo. a follow-up pr will automate this too.
pglinter works in a weird way where the user defines thresholds for certain rules. e.g.
I would much rather see the actual objects that have an uppercase in name...
Opened an issue to check in with the maintainer: pmpetit/pglinter#83