feat(splinter): allow ignoring db objects #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juleswritescode
approved these changes
Jan 2, 2026
crates/pgls_splinter/src/lib.rs
Outdated
| let diagnostics: Vec<SplinterDiagnostic> = results.into_iter().map(Into::into).collect(); | ||
| let mut diagnostics: Vec<SplinterDiagnostic> = results.into_iter().map(Into::into).collect(); | ||
|
|
||
| // Apply per-rule object filtering if rules config is provided |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Apply per-rule object filtering if rules config is provided |
crates/pgls_splinter/src/lib.rs
Outdated
| // Extract rule name from category (e.g., "splinter/performance/noPrimaryKey" -> "noPrimaryKey") | ||
| let rule_name = diag.category.name().split('/').next_back().unwrap_or(""); | ||
|
|
||
| // Look up pre-built matcher for this rule |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Look up pre-built matcher for this rule |
crates/pgls_splinter/src/lib.rs
Outdated
|
|
||
| // Look up pre-built matcher for this rule | ||
| if let Some(matcher) = rule_matchers.get(rule_name) { | ||
| // Build object identifier from schema and name |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Build object identifier from schema and name |
crates/pgls_splinter/src/lib.rs
Outdated
| { | ||
| let object_identifier = format!("{schema}.{name}"); | ||
|
|
||
| // If the object matches an ignore pattern, filter it out |
Collaborator
There was a problem hiding this comment.
Suggested change
| // If the object matches an ignore pattern, filter it out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds an
ignoresconfig option to allsplinterrules.the filter is applied in rust and not part of the query for more flexibility.
also: moved
matcherinto its own crate to allowsplinterto reuse it