Conversation
| let _e = pushenv("RUSTUP_TOOLCHAIN", "nightly"); | ||
| // Only set RUSTUP_TOOLCHAIN if nightly isn't already on PATH (e.g., in Nix) | ||
| let _e = if !is_nightly_rustfmt_available() { | ||
| Some(pushenv("RUSTUP_TOOLCHAIN", "nightly")) |
There was a problem hiding this comment.
wofür brauchen wir überhaupt nightly? nix für den PR, aber wir können vllt. einfach die Version nehmen, die in der rust-toolchaim.toml specified ist
There was a problem hiding this comment.
wir nutzen die version aus der toolchain file (2024) im repo, aber der format style ist noch nicht stable.
| } | ||
|
|
||
| // Then check per-rule ignore | ||
| let rule_name = diag.category.name().split('/').next_back().unwrap_or(""); |
There was a problem hiding this comment.
note: we might filter out rules with the same name but different categories, e.g.
lint/safety/rlsDislabed – findet statements wo DISABLE ROW LEVEL SECURITY steht
splinter/safety/rlsDisabled – findet tables, die schon existieren, bei denen RLS disabled ist
wenn du jetzt rlsDisabled irgendwo rein packst, disablest du beides, willst aber vllt. nur die zweite.
Klingt erstmal nach edge-case, könnte uns aber beißen
There was a problem hiding this comment.
die configs sind separat, und let rule_matchers = config.rules.get_ignore_matchers(); zieht sich nur die ignore config fuer den splinter.
Markdown tables need blank lines before headers to render properly. Without them, headers were being treated as table content.
- Add database_linting.md feature page - Add database_rules.md with Performance/Security rule groups - Add database_rule_sources.md with Splinter attribution - Extend codegen to generate splinter rules index and sources - Update navigation in mkdocs.yml
- Add taplo and nightly rustfmt to flake.nix - Extract only nightly rustfmt binary to avoid nightly rustc taking precedence over stable - Make xtask detect nightly rustfmt on PATH before falling back to RUSTUP_TOOLCHAIN env var
- Remove deprecated config warning from dblint test snapshots - Add missing execSync import in CLI bin script that was causing Linux tests to fail
Add top-level `ignore` field to splinter configuration that applies to
all rules, in addition to existing per-rule ignore.
Example configuration:
```json
{
"splinter": {
"ignore": ["audit.*", "temp_*"],
"rules": { ... }
}
}
```
psteinroe
force-pushed
the
chore/dblint-docs
branch
from
34754d5 to
6b52e89
Compare
2 participants
check each commit for changes
{ enabled: true }for all features in the initial config. some were just an empty object before.dblintignorefield to splinter configuration (applies to all rules)