Skip to content

3/11: feat(grammar): add benchmarks#656

Merged
juleswritescode merged 6 commits intostacked/pr629-2-grammar-guidelinesfrom
stacked/pr629-3-benchmarks
Jan 25, 2026
Merged

3/11: feat(grammar): add benchmarks#656
juleswritescode merged 6 commits intostacked/pr629-2-grammar-guidelinesfrom
stacked/pr629-3-benchmarks

Conversation

@juleswritescode
Copy link
Collaborator

@juleswritescode juleswritescode commented Jan 24, 2026

Summary

  • Add criterion dependency
  • Add parsing benchmarks
  • Add lookahead iterator benchmark

Part of stacked PRs for #629

This is PR 3/11 in the keyword completion feature stack.

@juleswritescode juleswritescode changed the title 3/8: feat(grammar): add benchmarks 3/11: feat(grammar): add benchmarks Jan 24, 2026
Copy link
Collaborator

@psteinroe psteinroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't criterion support writing benchmark results to a file vs adding comments?

@juleswritescode
Copy link
Collaborator Author

Doesn't criterion support writing benchmark results to a file vs adding comments?

it per default writes benchmarks to the /target directory.

I think the recommended approach isn't to store any results, tbh, because it'll differ so much on varying machines.

What we could do is running benchmarks on the same gh-runner machine and look for regressions.

In this case, it was only meant as a POC that updating the tree-sitter tree once for every checkable keyword is feasible 👍🏻

@juleswritescode juleswritescode merged commit a148c90 into stacked/pr629-2-grammar-guidelines Jan 25, 2026
8 checks passed
@juleswritescode juleswritescode deleted the stacked/pr629-3-benchmarks branch January 25, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants