3/11: feat(grammar): add benchmarks#656
Merged
juleswritescode merged 6 commits intostacked/pr629-2-grammar-guidelinesfrom Jan 25, 2026
Merged
3/11: feat(grammar): add benchmarks#656juleswritescode merged 6 commits intostacked/pr629-2-grammar-guidelinesfrom
juleswritescode merged 6 commits intostacked/pr629-2-grammar-guidelinesfrom
Conversation
added 5 commits
January 24, 2026 13:31
…om/supabase-community/postgres_lsp into stacked/pr629-3-benchmarks
…om/supabase-community/postgres_lsp into stacked/pr629-3-benchmarks
psteinroe
approved these changes
Jan 25, 2026
Collaborator
psteinroe
left a comment
There was a problem hiding this comment.
Doesn't criterion support writing benchmark results to a file vs adding comments?
Collaborator
Author
it per default writes benchmarks to the I think the recommended approach isn't to store any results, tbh, because it'll differ so much on varying machines. What we could do is running benchmarks on the same gh-runner machine and look for regressions. In this case, it was only meant as a POC that updating the tree-sitter tree once for every checkable keyword is feasible 👍🏻 |
a148c90
into
stacked/pr629-2-grammar-guidelines
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of stacked PRs for #629
This is PR 3/11 in the keyword completion feature stack.