Skip to content

9/11: refactor(test_utils): add field names to tree printing#663

Merged
juleswritescode merged 2 commits intostacked/pr629-8-grammar-fmtfrom
stacked/pr629-9-print-utils
Jan 25, 2026
Merged

9/11: refactor(test_utils): add field names to tree printing#663
juleswritescode merged 2 commits intostacked/pr629-8-grammar-fmtfrom
stacked/pr629-9-print-utils

Conversation

@juleswritescode
Copy link
Collaborator

@juleswritescode juleswritescode commented Jan 24, 2026

Summary

  • Update print_ts_tree signature to include field names in output
  • Show (@field_name) suffix for tree nodes
  • Update grammar tests to use new signature

Part of stacked PRs for #629

This is PR 9/11 in the keyword completion feature stack.

- `crates/pgls_completions/src/providers/keywords.rs` (remove #[ignore])
- `crates/pgls_completions/src/providers/roles.rs`
- `crates/pgls_completions/src/providers/tables.rs`
- `crates/pgls_completions/src/relevance/filtering.rs` (remove #[ignore])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obsolete?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes :) was removed by PR 11

@juleswritescode juleswritescode merged commit 968422a into stacked/pr629-8-grammar-fmt Jan 25, 2026
8 checks passed
@juleswritescode juleswritescode deleted the stacked/pr629-9-print-utils branch January 25, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants